Skip to content

Align Progress snackbar styles with Figma per QA feedback#12683

Merged
tofumatt merged 11 commits into
mainfrom
enhancement/12508-progress-snackbar-style-fixes
May 12, 2026
Merged

Align Progress snackbar styles with Figma per QA feedback#12683
tofumatt merged 11 commits into
mainfrom
enhancement/12508-progress-snackbar-style-fixes

Conversation

@shervElmi

@shervElmi shervElmi commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Enhance the color of the tertiary button in the PDF report progress
snackbar to ensure better contrast and visibility for users.
@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

🎭 Playwright reports for 712ae0a:

📚 Storybook for 712ae0a:

  • Storybook has been deleted.

📦 Build files for 712ae0a:

  • Build files have been deleted.

shervElmi added 4 commits May 11, 2026 12:36
Updated the ProgressBar component to include a CSS variable for progress
and adjusted the snackbar styles to maintain rounded corners during
scaling. This improves the overall appearance and user experience.
Refactor CSS variable names to improve readability and maintainability.
This change ensures that the progress bar and snackbar styles are aligned
with the updated naming conventions.
Refactor the style application for the progress bar to ensure that the
custom property '--googlesitekit-progress' is only set when progress
is defined. This enhances the clarity and maintainability of the
component's styling.
Updated the paragraph styles within the snackbar to ensure better
visual consistency and clarity in the presentation of content.
@tofumatt tofumatt changed the base branch from develop to main May 11, 2026 20:40
shervElmi added 6 commits May 12, 2026 09:13
Refine the primary bar's width and transform properties to ensure
better rendering of progress states. This enhances the visual
consistency of the progress bar component.
Adjust the progress bar styles in the PDFReportProgressSnackbar tests
to ensure the width is set correctly without transform effects.
This enhances the visual representation of progress updates.
This change simplifies the styling of the progress bar by eliminating
transform properties that were affecting the rounded corners.
Improving the visual consistency of the progress snackbar.
This change improves the animation of the primary bar in the linear
progress component, ensuring that determinate progress fills smoothly.
Adjust font size, letter spacing, and line height for better
visual consistency in the snackbar content.
This change includes updated binary files for the PDF export progress
snackbar, ensuring accurate visual representation during testing.
@shervElmi shervElmi marked this pull request as ready for review May 12, 2026 09:32
@shervElmi

Copy link
Copy Markdown
Collaborator Author

The Run VR Tests failure isn't from this PR's changes.

@tofumatt tofumatt merged commit 23e54b9 into main May 12, 2026
47 of 48 checks passed
@tofumatt tofumatt deleted the enhancement/12508-progress-snackbar-style-fixes branch May 12, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants